Keep track of generated and transformed classes to avoid lookups #51428
+81
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It happens quite often that a given directory has a couple of generated/transformed classes and in this case we hit the generated/transformed-bytecode jars for each lookup in this directory, even for the regular case of the class being in the "standard" jars. Keeping track of generated and transformed classes allows to avoid this additional work with minimal added cost. In my testing, it dropped 10 ms from the startup time, going from 367 to 353ms for a simple Quarkus REST app.
When possible and not too much hassle. It doesn't bring that much but still it's good hygiene given how critical this path is.
quarkus-bot
bot
added
the
area/devtools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It happens quite often that a given directory has a couple of
generated/transformed classes and in this case we hit the
generated/transformed-bytecode jars for each lookup in this directory,
even for the regular case of the class being in the "standard" jars.
Keeping track of generated and transformed classes allows to avoid this
additional work with minimal added cost.
In my testing, it dropped 10 ms from the startup time, going from 367 to
353ms for a simple Quarkus REST app.
There's also an additional commit for a tiny improvement.